Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Make reference stories consistent #20759

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Docs: Make reference stories consistent #20759

merged 4 commits into from
Jan 24, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 24, 2023 •
edited
Loading

Telescoping on #20723

Issue: #NA

What I did

  • Updated all reference stories to have consistent names
  • Moved Story block reference stories

What I didn't do (yet?)

  • Add stories for props/parameters conflicts
  • Rename all stories to be consistent (in the style of the Description stories)

How to test

Check SB

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested a review from JReinhold January 24, 2023 06:23
@tmeasday tmeasday changed the base branch from next to jeppe/sb-1145-update-api-of-canvas-block January 24, 2023 06:23
@tmeasday tmeasday changed the title Make reference stories consistent Docs: Make reference stories consistent Jan 24, 2023
@tmeasday tmeasday added maintenance User-facing maintenance tasks addon: docs labels Jan 24, 2023
JReinhold
JReinhold approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from jeppe/sb-1145-update-api-of-canvas-block to next January 24, 2023 09:32
@tmeasday tmeasday merged commit 1c7d2fa into next Jan 24, 2023
@tmeasday tmeasday deleted the tom/sb-1179-make-reference-stories-consistent branch January 24, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees
No one assigned
Labels
addon: docs maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @JReinhold